-
Notifications
You must be signed in to change notification settings - Fork 6
[WIP] Implementing BOLT 04 - Onion Routing #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
pegasusjcrawford
wants to merge
36
commits into
block-core:master
Choose a base branch
from
pegasusjcrawford:feature/onion-routing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[WIP] Implementing BOLT 04 - Onion Routing #30
pegasusjcrawford
wants to merge
36
commits into
block-core:master
from
pegasusjcrawford:feature/onion-routing
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'s implementation
…d length reference test vectors
…(incorrectly in some cases?)
First hop of reference vector works, but session key logic is currently busted causing subsequent hops to be wrong
…payloads & keys look appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this PR as a draft as it's definitely not ready to be merged yet. Have made some decent progress on implementing portions of BOLT 04 based on Eclair's implementation, but I figure getting some code out in the open will help me pick up the slack
Here's a (rough) overview of the state of this branch, though there may be un-enumerated work as I'm still grokking the BOLT spec fully 😅
I'm also looking for feedback on the way I've structured the implementation and whether or not I'm missing anything from the list above. Thanks 😸